[frontend/backend] add inject result inside report #1519
Conversation
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
github-actions
bot
added
the
filigran team
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1519 +/- ##
============================================
+ Coverage 32.55% 32.61% +0.05%
- Complexity 1464 1470 +6
============================================
Files 534 535 +1
Lines 13766 13796 +30
Branches 824 827 +3
============================================
+ Hits 4482 4500 +18
- Misses 9075 9084 +9
- Partials 209 212 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| ReportInjectComment reportInjectComment = report.getReportInjectsComments().stream() | ||
| .filter(c -> c.getInject().getId().equals(input.getInjectId())) | ||
| .findFirst() | ||
| .orElse(null); |
There was a problem hiding this comment.
Can we have the direct query to do that ?
To avoid hibernate to lazy load too much datas
| @@ -18,7 +18,7 @@ const ERROR_30S_DELAY = 30000; | |||
| let sseClient; | |||
| let lastPingDate = new Date().getTime(); | |||
| const listeners = new Map(); | |||
| const useDataLoader = (loader = () => {}) => { | |||
| const useDataLoader = (loader = () => {}, refetchArg = []) => { | |||
There was a problem hiding this comment.
Can you explain this changes ?
Thank you
| {t('Injects results')} | ||
| </Typography> | ||
|
|
||
| <TableContainer component={Paper}> |
There was a problem hiding this comment.
I am not sure this is the UI we want
The background and the border are differents
| <TableRow> | ||
| {columns.map((col) => ( | ||
| <TableCell | ||
| sx={col.label === 'Comment' ? { padding: '0px', width: '35%', flexGrow: 1 } : {}} |
There was a problem hiding this comment.
| sx={col.label === 'Comment' ? { padding: '0px', width: '35%', flexGrow: 1 } : {}} | |
| sx={col.label === 'Comments' ? { padding: '0px', width: '35%', flexGrow: 1 } : {}} |
| const currentInjectComment = findInjectCommentsByInjectId(inject.inject_id); | ||
|
|
||
| return (editInjectId === inject.inject_id | ||
| ? <TextField |
There was a problem hiding this comment.
This is a new behavior in the OpenBAS platform.
Are we sure this is what we want ?
| } | ||
|
|
||
| @JsonProperty("report_id") | ||
| public String getReportId() { |
There was a problem hiding this comment.
reportId is String here and UUID in ReportInjectCommentId ?
I don't understand
issue : #1080
Chunk 2
add result inject inside report
