Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Centroid in window_dict output #840

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Add Centroid in window_dict output #840

merged 8 commits into from
Jul 24, 2024

Conversation

KrishPatel13
Copy link
Collaborator

@KrishPatel13 KrishPatel13 commented Jul 7, 2024

What kind of change does this PR introduce?

Summary

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

Other information

@KrishPatel13 KrishPatel13 self-assigned this Jul 7, 2024
@KrishPatel13
Copy link
Collaborator Author

KrishPatel13 commented Jul 7, 2024

@abrichr Any suggestion on how to test this PR practically?
I have tried theoretically here:
image

Reference: https://stackoverflow.com/a/18932029

@KrishPatel13 KrishPatel13 linked an issue Jul 7, 2024 that may be closed by this pull request
@KrishPatel13 KrishPatel13 requested a review from abrichr July 7, 2024 20:06
@KrishPatel13 KrishPatel13 marked this pull request as ready for review July 7, 2024 20:06
@KrishPatel13
Copy link
Collaborator Author

Ready for review @abrichr !

Copy link
Member

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @KrishPatel13 ! Just a few small comments.

openadapt/models.py Outdated Show resolved Hide resolved
openadapt/models.py Outdated Show resolved Hide resolved
openadapt/models.py Outdated Show resolved Hide resolved
@KrishPatel13
Copy link
Collaborator Author

@abrichr Ready for Review!

@abrichr abrichr merged commit 5118b39 into main Jul 24, 2024
1 check passed
@abrichr abrichr deleted the feat/centroid branch July 24, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify WindowEvent.to_prompt_dict to include computed centroid
2 participants