fix(install): improve powershell script (Issue #372)

[KrishPatel13]

What kind of change does this PR introduce?
This PR resolves the bugs numbered here #372 (comment)

Summary
Bug Number fixed:

• 1
• 2
• 3 (further information is needed for resolution) So to mark it as resolved for now read: fix(install): improve powershell script (Issue #372) #409 (comment)
• 4
• 5
• 6

Checklist

• My code follows the style guidelines of OpenAdapt
• I have performed a self-review of my code
• If applicable, I have added tests to prove my fix is functional/effective
• I have linted my code locally prior to submission
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
• New and existing unit tests pass locally with my changes

How can your code be run and tested?

Other information

[KrishPatel13]

Bug 4 (from #372 (comment))

Resolution Transcript (f39c583):

PS C:\Users\Krish Patel> python -V
Python 3.10.11
PS C:\Users\Krish Patel> $pythonMinVersion = "3.10.0" # Change this if a different Lower version are supported by OpenAdapt
PS C:\Users\Krish Patel> $pythonMaxVersion = "3.10.12" # Change this if a different HIgher version are supported by OpenAdapt
PS C:\Users\Krish Patel> function ComparePythonVersion($version) {
>>     $v = [version]::new($version)
>>     $min = [version]::new($pythonMinVersion)
>>     $max = [version]::new($pythonMaxVersion)
>>
>>     return $v -ge $min -and $v -le $max
>> }
PS C:\Users\Krish Patel> $res = Invoke-Expression "python -V"
PS C:\Users\Krish Patel>         $versionString = $res.Split(' ')[-1]
PS C:\Users\Krish Patel> $res
Python 3.10.11
PS C:\Users\Krish Patel> $versionString
3.10.11
PS C:\Users\Krish Patel> if (ComparePythonVersion $versionString  $pythonMaxVersion) {
>>             return $true
>>         }
True
PS C:\Users\Krish Patel> if (ComparePythonVersion $versionString  $pythonMaxVersion) {
>>             return "correct version found"
>>         }
correct version found
PS C:\Users\Krish Patel> $versionString = "3.11.0"
PS C:\Users\Krish Patel> if (ComparePythonVersion $versionString  $pythonMaxVersion) {
>>             return "correct version found"
>>         }
PS C:\Users\Krish Patel> if (ComparePythonVersion $versionString  $pythonMaxVersion) {
>>             return "correct version found"
>>         } else {
>> return "incorrect version found"
>> }
incorrect version found
PS C:\Users\Krish Patel> $versionString = "3.9.99"
PS C:\Users\Krish Patel> if (ComparePythonVersion $versionString  $pythonMaxVersion) {
>>             return "correct version found"
>>         } else {
>> return "incorrect version found"
>> }
incorrect version found
PS C:\Users\Krish Patel> $versionString = "3.10.0001"
PS C:\Users\Krish Patel> if (ComparePythonVersion $versionString  $pythonMaxVersion) {
>>             return "correct version found"
>>         } else {
>> return "incorrect version found"
>> }
correct version found
PS C:\Users\Krish Patel> $versionString = "3.10.12"
PS C:\Users\Krish Patel> if (ComparePythonVersion $versionString  $pythonMaxVersion) {
>>             return "correct version found"
>>         } else {
>> return "incorrect version found"
>> }
correct version found

[KrishPatel13]

Bug 1 and 2 (from #372 (comment)):

Resolution Commit: ed7f3e0

Resolution Transcript:
Issue 1&2 Resolution Documentation:

Some Improvement in CheckCMDExists function:

Old Function Terminal Transcript:

PS C:\Users\Krish Patel> function CheckCMDExists {
>>     Param
>>     (
>>         [Parameter(Mandatory = $true)] [string] $command
>>     )
>>
>>     Get-Command $command -errorvariable getErr -erroraction 'silentlycontinue'
>>     if ($null -eq $getErr) {
>>         return $true
>>     }
>>     return $false
>> }
PS C:\Users\Krish Patel> CheckCMDExists "got"
False
PS C:\Users\Krish Patel> CheckCMDExists "git"

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     git.exe                                            2.41.0.1   C:\Program Files\Git\cmd\git.exe
False


PS C:\Users\Krish Patel> CheckCMDExists "tesseract"

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     tesseract.exe                                      0.0.0.0    C:\Program Files\Tesseract-OCR\tessera...
False


PS C:\Users\Krish Patel> CheckCMDExists "python"

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     python.exe                                         3.10.11... C:\Program Files\Python310\python.exe
False

Updated Function Code for Terminal Transcript:

PS C:\Users\Krish Patel> function CheckCMDExists {
>>     Param
>>     (
>>         [Parameter(Mandatory = $true)] [string] $command
>>     )
>>
>>     $result = Get-Command $command -errorvariable getErr -erroraction 'silentlycontinue'
>>     if ($null -eq $result) {
>>         return $false
>>     }
>>     return $true
>> }
PS C:\Users\Krish Patel> CheckCMDExists "got"
False
PS C:\Users\Krish Patel> CheckCMDExists "git"
True
PS C:\Users\Krish Patel> CheckCMDExists "tesseract"
True
PS C:\Users\Krish Patel> CheckCMDExists "python"
True
PS C:\Users\Krish Patel> CheckCMDExists "python 3.10"
False
PS C:\Users\Krish Patel> CheckCMDExists "py"
True
PS C:\Users\Krish Patel> CheckCMDExists "tess"
False

Updated code for the function:

function CheckCMDExists {
    Param
    (
        [Parameter(Mandatory = $true)] [string] $command
    )

    $result = Get-Command $command -errorvariable getErr -erroraction 'silentlycontinue'
    if ($null -eq $result) {
        return $false
    }
    return $true
}

Conclusion: The previous old function was incorrect and did not work as expected on Unit Testing as shown in the transcripts.

[KrishPatel13]

Bug 5 and 6 (from #372 (comment)):

Resolution Commit: cf0d21d

Resolution Documentation:
microsoft/vscode-python#2559 (comment)

[KrishPatel13]

Bug 3:

Update:

Commit: 56cf2c1

[KrishPatel13]

@abrichr Ready for review!

[KrishPatel13]

@abrichr Ready for Final Review and merging! :)