Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] use Files.createTempFile instead #8787

Merged
merged 3 commits into from
Feb 23, 2021
Merged

[Java] use Files.createTempFile instead #8787

merged 3 commits into from
Feb 23, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 22, 2021

  • use Files.createTempFile instead to avoid potential security issues.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wing328 wing328 marked this pull request as ready for review February 23, 2021 03:39
@wing328 wing328 merged commit 1b6cabb into master Feb 23, 2021
@wing328 wing328 deleted the java-lib-temp branch February 23, 2021 03:40
@Sarangan0219
Copy link

Sarangan0219 commented Jan 11, 2022

Hi @wing328

Currently we are using openapi-generator 4.3.1, and when downloading JAVA SDK for endpoints with PDF files, we couldn't observe any temporary files in /tmp orvar/tmp folder. Could you please tell me how we can reproduce this issue ?

@wing328
Copy link
Member Author

wing328 commented Jan 11, 2022

please try the latest stable version v5.3.1 instead and open a new issue for tracking if you need help from the community.

@Sarangan0219
Copy link

yes with stable version v5.3.1 we have no issues. I just want to analyze this issue in my environment with the previous versions. Could you please let me know the steps to reproduce this in previous versions ?

@wing328
Copy link
Member Author

wing328 commented Jan 11, 2022

the issue was reported by a user and he didn't provide details on how exactly he uncovered the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants