Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert all text/* content types to strings in the apache http java client #18731

Conversation

aaronforest-wf
Copy link
Contributor

@aaronforest-wf aaronforest-wf commented May 22, 2024

fix #18730

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@aaronforest-wf aaronforest-wf marked this pull request as ready for review May 22, 2024 03:59
@aaronforest-wf
Copy link
Contributor Author

Ready for review

Java Apache Http template creators:
@harrywhite4 @andrevegas

Java technical committee:
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

@wing328
Copy link
Member

wing328 commented May 22, 2024

@aaronforest-wf thanks for the PR, which looks good to me.

will merge if all tests pass.

@aaronforest-wf
Copy link
Contributor Author

Thank you @wing328!

@wing328 wing328 merged commit 235b57e into OpenAPITools:master May 23, 2024
73 checks passed
@wing328 wing328 added Client: Java Issue: Bug java Pull requests that update Java code labels May 23, 2024
@wing328 wing328 added this to the 7.7.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Java Issue: Bug java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][Java][Client] add support for text/csv content
2 participants