Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double-callback issue #1385

Merged
merged 1 commit into from
May 5, 2022
Merged

Fix double-callback issue #1385

merged 1 commit into from
May 5, 2022

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented May 4, 2022

Fixes #1015

A previous fix didn't work because of flawed logic. We were nulling the copy of the callback which was needed since the Callback argument was final.

This change utilizes a final callback array which works around the final object requirement since arrays can be final and still mutable.


This change is Reviewable

@rgomezp rgomezp requested review from jkasten2 and removed request for jkasten2 May 4, 2022 19:37
@rgomezp rgomezp requested review from jkasten2 and nan-li May 4, 2022 19:48
@nan-li
Copy link
Contributor

nan-li commented May 4, 2022

Nice that final was not needed.
Were you able to test? I can reproduce a callback firing twice, so I will test it out.

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nan-li)

Copy link
Contributor

@nan-li nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Noting that send outcome methods don't have callbacks checked but that should not be necessary because they shouldn't be invoked twice, unlike setting EUID.

@rgomezp rgomezp merged commit 5bc41c3 into main May 5, 2022
@rgomezp rgomezp deleted the fix/double-callback branch May 5, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Exception: java.lang.RuntimeException
3 participants