-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Add Dispatch Queues to all executors #1454
Commits on Jun 24, 2024
-
[tests] make Mock Client use a concurrent DispatchQueue
* When testing concurrency, the Mock Client actually was synchronizing the requests, so crashes were not reproducible * By changing to a concurrent DispatchQueue, this is more reflective of the real Client's behavior
Configuration menu - View commit details
-
Copy full SHA for 58ef7a1 - Browse repository at this point
Copy the full SHA 58ef7a1View commit details -
[tests] Mock Client has flag to let all requests through
* Add a flag called `fireSuccessForAllRequests` that will fire the success callback for all requests so that they don't need to be manually set up using mock responses beforehand. * This is useful for tests that want the client to return success but don't need the details of particular requests.
Configuration menu - View commit details
-
Copy full SHA for f2869a8 - Browse repository at this point
Copy the full SHA f2869a8View commit details -
Add dispatch queue to Subscription Executor
* Synchronize access to the delta queue and request queues * Add test `testSubscriptionExecutorConcurrency` that reproduced crash that is then fixed by the changes here.
Configuration menu - View commit details
-
Copy full SHA for 63140d4 - Browse repository at this point
Copy the full SHA 63140d4View commit details -
Add dispatch queue to Identity Executor
* Synchronize access to the delta queue and request queues * Add test `testIdentityExecutorConcurrency` that reproduced crash that is then fixed by the changes here.
Configuration menu - View commit details
-
Copy full SHA for 6535737 - Browse repository at this point
Copy the full SHA 6535737View commit details -
Add dispatch queue to User Executor
* Synchronize access to the request queues * Add test `testUserExecutorConcurrency` that reproduced crash that is then fixed by the changes here. * Note that concurrent access in this executor should be mitigated already by the executor only sending one request at a time.
Configuration menu - View commit details
-
Copy full SHA for ec7d7e9 - Browse repository at this point
Copy the full SHA ec7d7e9View commit details -
[tests] add a test for Property Executor Concurrency
* Add test `testPropertyExecutorConcurrency`
Configuration menu - View commit details
-
Copy full SHA for ca7fafa - Browse repository at this point
Copy the full SHA ca7fafaView commit details
Commits on Jun 26, 2024
-
[nit] Break up User Executor code
* swiftlint error: Type Body Length Violation: Type body should span 350 lines or less excluding comments and whitespace: currently spans 354 lines (type_body_length) * No logic changes in this commit, only split up executing requests code into an extension
Configuration menu - View commit details
-
Copy full SHA for a90478c - Browse repository at this point
Copy the full SHA a90478cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8248762 - Browse repository at this point
Copy the full SHA 8248762View commit details