Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] swizzle of deprecated didReceiveRemoteNotification #1094

Merged
merged 2 commits into from
May 26, 2022
Merged

[Fix] swizzle of deprecated didReceiveRemoteNotification #1094

merged 2 commits into from
May 26, 2022

Commits on May 24, 2022

  1. Add failing test for deprecated remote received

    @jkasten2
    jkasten2 committed May 24, 2022
    Configuration menu
    Copy the full SHA
    9c6ea40 View commit details
    Browse the repository at this point in the history

  2. Fix forwarding didReceiveRemoteNotification 

    While didReceiveRemoteNotification has been deprecated for a while there
may still be some older apps still expecting this to be called and
OneSignal should not cause any side effects.
Apple's iOS logic is both didReceiveRemoteNotification and
didReceiveRemoteNotification:fetchCompletionHandler are defined only the
newer API will be called. This means OneSignal must also replicate this
logic to prevent side effects.
https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623117-application?language=objc

Also removed our swizzling on didReceiveRemoteNotification as we no
longer support iOS 6. Apple added
application:didReceiveRemoteNotification:fetchCompletionHandler: in iOS
7 so we could have dropped this swizzling awhile ago.
    @jkasten2
    jkasten2 committed May 24, 2022
    Configuration menu
    Copy the full SHA
    9f09fa5 View commit details
    Browse the repository at this point in the history