Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log a warning when external features path has no assemblies #2202

Merged
merged 1 commit into from
Jul 31, 2021
Merged

log a warning when external features path has no assemblies #2202

merged 1 commit into from
Jul 31, 2021

Conversation

filipw
Copy link
Member

@filipw filipw commented Jul 30, 2021

Fixes #2201

bjorkstromm
bjorkstromm approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd use Count > 0 instead of Any(), but in this case it doesn't really matter. Any() reads better.

@filipw filipw merged commit e55adb0 into master Jul 31, 2021
@filipw filipw deleted the feature/log-external-features-warning branch July 31, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorkstromm bjorkstromm bjorkstromm approved these changes

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

@david-driscoll david-driscoll Awaiting requested review from david-driscoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error notification when LocationPaths is missing .dll file(s)
2 participants
@filipw @bjorkstromm