Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 feat: add partial take profit triggers #114

Merged

Conversation

halaprix
Copy link
Member

  • add two new trigger types for aave nd spark
  • add trigger data types and names
  • add a convenient array including trailig stop loss trigger types

Copy link

This pull request has been linked to Shortcut Story #14517: [lib] - common/automation - add missing triggers.

'uint256', // targetLtv
'uint256', // excutionPrice
'uint64', // deviation
'bool', // closeToCollateral
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is it closeToColalteral or withdrawToDebt @halaprix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably withdrawToDebt

@halaprix halaprix marked this pull request as ready for review March 4, 2024 18:43
@halaprix halaprix merged commit 59eb3ee into main Mar 4, 2024
1 check failed
@halaprix halaprix deleted the kk/sc-14517/lib-common-automation-add-missing-triggers branch March 4, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants