Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added LF line ending #2465

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sarthak5598
Copy link
Member

No description provided.

Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax look fine.
I'm not sure if this introduces any side effects. Anyway, it can always be rolled back.

It also looks like you should do

git rm --cached -r .
git add .

to apply the changes to the code base.

*.md text

# Declare files that will always have CRLF line endings on checkout.
*.sln text eol=crlf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's this file type. Do we need it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used almost in every gitattributes file , It is basically for visual studio solution files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Are we going to have any in the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants