Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous Notification #2370

Closed
wants to merge 156 commits into from

Conversation

HanilJain
Copy link
Contributor

Asynchronous Notification

Issue Addressed

#2213
#2214
#2215
#2216
#2217
#2218
#2221

How it works

  • Notification is created in model of notification_app
  • new_home frontend fetch api Notification.
  • websockets in header.html file handles the notification coming and managed by redis-server
  • redis-server handles the cache and channel serving the notification to webscoket at port 6379
  • when user click on notification it gets deleted from database

Image

image

Note

There can be issue with combability with pythonanywhere so before merigng please confirm it once.
This PR just for code correction and suggestion.

Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HanilJain could you remove the unrelated 5000+ files (virtual environment?) from the PR and make the commit history clean by squashing the 150+ commits?
Thank you!

Screenshot 2024-06-25 at 9 20 13 AM

Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure the pre-commit runs green locally before pushing it to GitHub.

@HanilJain HanilJain closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants