Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Bug Details Page, Task - 1 #1956

Closed
wants to merge 12 commits into from
Closed

Enhancement: Bug Details Page, Task - 1 #1956

wants to merge 12 commits into from

Conversation

CodeWithBishal
Copy link
Contributor

@CodeWithBishal CodeWithBishal commented Mar 6, 2024

related #1627

Title and Open Graph Tags

Meta tags are now dynamically updating

moved issue.html to REMOVE folder signifying it can be removed and no longer required likewise issue2.html can be moved after issue3.html is ready

Screenshot 2024-03-07 at 10 12 07 PM

Copy link

sentry-io bot commented Mar 6, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: website/views.py

Function Unhandled Issue
get_context_data AttributeError: 'NoneType' object has no attribute 'user_subscribed_domains' ...
Event Count: 23

Did you find this useful? React with a 👍 or 👎

@CodeWithBishal CodeWithBishal changed the title issue 1627 - 1 Enhancement: Bug Details Page, Task - 1 Mar 6, 2024
@CodeWithBishal
Copy link
Contributor Author

@DonnieBLT can I get more information on this?

## Title and Open Graph Tags

Meta tags are now dynamically updating

moved issue.html to REMOVE folder signifying it can be removed and no longer required
likewise issue2.html can be moved after issue3.html is ready
## Title and Open Graph Tags

Meta tags are now dynamically updating

moved issue.html to REMOVE folder signifying it can be removed and no longer required
likewise issue2.html can be moved after issue3.html is ready
DonnieBLT
DonnieBLT previously approved these changes Mar 8, 2024
@DonnieBLT DonnieBLT enabled auto-merge (squash) March 8, 2024 05:54
@DonnieBLT
Copy link
Collaborator

I tried to fix the conflict but it didn't work, can you please confirm the base.html file change for the content div? @CodeWithBishal

@CodeWithBishal
Copy link
Contributor Author

CodeWithBishal commented Mar 8, 2024

@DonnieBLT Please take a look at this
https://github.com/CodeWithBishal/OWASP-BLT/blob/enhancement/issue-1627-2/website/templates/base.html

My changes are mostly inside of {% block metaTags %} {% endblock metaTags %}

precommit might fail due to spacing and indentation, please check with pre-commit run --all-files

@DonnieBLT
Copy link
Collaborator

Yes I had to step afk will fix tonight unless you get to it before me. Thanks!

should fix the conflict
auto-merge was automatically disabled March 8, 2024 16:12

Head branch was pushed to by a user without write access

@CodeWithBishal
Copy link
Contributor Author

@DonnieBLT Fixed merged conflicts, can you kindly look at why the test is failing?

https://github.com/OWASP-BLT/BLT/actions/runs/8206165237/job/22444812830?pr=1956

@DonnieBLT
Copy link
Collaborator

This was merged, reopen if we missed anything.

@DonnieBLT DonnieBLT closed this Mar 12, 2024
@CodeWithBishal CodeWithBishal deleted the enhancement/issue-1627-1 branch June 20, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants