Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing range error when no screenShot for issue is there #357

Closed
wants to merge 2 commits into from
Closed

Fixing range error when no screenShot for issue is there #357

wants to merge 2 commits into from

Conversation

Dante291
Copy link
Contributor

fixes #356

Basically we were getting range error because we were trying to access first element of screenshots list of an issue which was null so I added a null check such that if list is null we show a default issue image.

Screenshot_1708799047

@Dante291
Copy link
Contributor Author

@DonnieBLT Let me know if this default image (bug image which matches BLT theme) for an issue with no screenshots is ok?

@DonnieBLT
Copy link
Collaborator

There should be no issues without screenshots. That's a bug that we've been having that needs to be fixed so I think what we can do instead is just don't show the issue. How about that?

@Dante291
Copy link
Contributor Author

There should be no issues without screenshots. That's a bug that we've been having that needs to be fixed so I think what we can do instead is just don't show the issue. How about that?

Alright then we need a check to see if there is any screenshot for a issue, if no then dont show that issue also should i add a functionnality in the app that user shouldn't be able to create an issue if there is no screenshot attached?

@DonnieBLT
Copy link
Collaborator

That would be good. Thanks so much.

@Dante291 Dante291 closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix valid range issue
2 participants