-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install VcPkg/Pkg-Config depending on target env #56
Conversation
Pull Request Test Coverage Report for Build 810866131Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@filips123 the change is good. Could you add a note on the |
and ... as you're involved in Windows GNU support, maybe you could prepare another PR adding a CI check for it? |
Sure.
I will probably try next week. |
68ae77b
to
3f5d4a0
Compare
I added CI check for Windows GNU. Most tests are passing, but there is a segmentation fault (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION) while running integration test: https://github.com/filips123/compress-tools-rs/runs/2544416808#step:10:129 I think it's caused by |
It is likely to be the case. For it to run a proper locale must be in use. Try setting |
Unfortunately that didn't help. |
@filips123 this is indeed quite hard to figure out without a proper environment to try it. The code involved in this is: compress-tools-rs/src/ffi/locale.rs Lines 50 to 91 in 6eaf5af
Please see if you can reproduce it on your Windows machine. |
Yes, I can reproduce it. |
So we'll need to figure out if the MSVC and GNU Windows support use the same schema for locale. I have no idea. |
Although #39 was merged,
Cargo.toml
still required VcPkg on Windows, regardless of used toolchain. This meant that when someone tried to buildcompress-tools
onwindows-gnu
, build script failed because it wasn't able to findpkg-config
module.This PR updates
Cargo.toml
to require either VcPkg or Pkg-Config depending on target env, just likebuild.rs
since #39. It also updates docs and readme to indicate this.