-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when uncompressing specific files from 7z archives #48
Conversation
Pull Request Test Coverage Report for Build 554607987Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
8652b29
to
22fb769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Asakiz the tests, on AArch64 and ARMv7 are failing. Could you take a look? |
We need libarchive 3.2.0 at least to properly support the 7z archive format, so we upgraded that on the validation Docker images used in cross. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
22fb769
to
422b70d
Compare
@Asakiz I successfully fixed the CI tests. As you mentioned the minimal version we need is |
There are some archive formats which require the seeking support, such as 7z archives. This commit add support for the seeking of those archives, fixing 7z uncompressing. Fixes: #46. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Signed-off-by: asakiz <asakizin@gmail.com>
422b70d
to
6ecea2d
Compare
tests: Add a test case for
uncompress_archive_file
using 7z fileSigned-off-by: Otavio Salvador otavio@ossystems.com.br
Signed-off-by: asakiz asakizin@gmail.com