-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor split-beam processing and add BB with pc option #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge and interpolating of cal params
…ta type in _get_interp_da
…ll need to test these
…_params; still need to do the same for CalibrateEK60 and CalibrateAZFP
…wn new tests needed
Co-authored-by: Don Setiawan <landungs@uw.edu>
Co-authored-by: Don Setiawan <landungs@uw.edu>
Co-authored-by: Don Setiawan <landungs@uw.edu>
Co-authored-by: Don Setiawan <landungs@uw.edu>
Co-authored-by: Don Setiawan <landungs@uw.edu>
for more information, see https://pre-commit.ci
Co-authored-by: Don Setiawan <landungs@uw.edu>
Co-authored-by: Don Setiawan <landungs@uw.edu>
…into fix-split-beam
for more information, see https://pre-commit.ci
lsetiawan
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Don Setiawan <landungs@uw.edu>
…into fix-split-beam
Co-authored-by: Don Setiawan <landungs@uw.edu>
…into fix-split-beam
Co-authored-by: Don Setiawan <landungs@uw.edu>
…into fix-split-beam
…e, keep beam dim removal in get_angle_power_sample
Found a missing test case for EK80 CW power data. I am pretty sure the code works right now, but don't have Echoview dongle to produce a comparison dataset. Will get this PR merged and add this later. |
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR completely refactors the split-beam processing code and addresses #890.
Details
Immediately related to split-beam processing
get_angle_complex_samples
, which:beam_type
Others
angle_sensitivity_*
toCAL_PARAMS
angle_sensitivity_*
andbeamwidth_*
in cal params constructionget_filter_coeff()
andget_vend_filter_EK80()
toek80_complex.py
test_consolidate.py
totest_consolidate_integration.py
Note this built on top of #955 so need to pull in
dev
once that is merged.