Redo: Implement add_splitbeam_angle function
#916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…incorporate new waveform/encode mode check into calibrate_ek and consolidate api
…ncode_mode to compute_Sv and compute_TS
…mplementation of _get_splitbeam_angle_power_CW, _add_splitbeam_angle_to_ds, add an empty test suite for echodata.simrad, and start working on test_add_splitbeam_angle
…orresponding to the encode mode
…at paths, construct a function that creates a numpy array from mat paths, and select echodata beam_group data in add_splitbeam_angle based on ds channel dims
…mplex) and (BB, complex, no pulse compression) options, and create tests for them
… location, finish docstring for add_splitbeam_angle, drop beam wherever necessary
…lit-beam angle tests data exists
…and allow it to handle a DataArray input, modify existing tests for validate_source_ds
…s for the core method in apply_mask
… add associated test in test_apply_mask
… provided as a path
…ue)=DataArray conflict with xr.where
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
…0 as it is not necessary
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
…splitbeam_angle Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
…ding of path and list (#908) * Expand prov.source_files_vars to support path sequences that mix a str/path and another sequence * For EK80, ES70, ES80, EA640, conversion was inserting an unnecessary, empty meta_source_filenames variable * Add more comprehensive and readable prov source-files type hints; rename _source_files * Fix prov type hint bug with Py 3.8 * Add unit test for prov _sanitize_source_files; plus small fixes to np.ndarray type references in prov
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
…s not equal to zero
…litbeam and then remove them
for more information, see https://pre-commit.ci
…into add-splitb-ang
Codecov Report
@@ Coverage Diff @@
## new_dev #916 +/- ##
===========================================
- Coverage 78.71% 73.45% -5.27%
===========================================
Files 56 26 -30
Lines 5253 2034 -3219
===========================================
- Hits 4135 1494 -2641
+ Misses 1118 540 -578
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lsetiawan
pushed a commit
to lsetiawan/echopype
that referenced
this pull request
Feb 27, 2023
See OSOceanAcoustics#894 for all conversations and detailed commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redos #894. See #894 for all conversations.
This is part of the fix to ensure that we have a clean squash-and-merge history on
devand eventuallymain.