Redo: Fix meta_source_filenames bug and enable (meta)source_filenames appending of path and list #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/path and another sequence; will add error checking
… empty meta_source_filenames variable
…ame _source_files
….ndarray type references in prov
lsetiawan
pushed a commit
to lsetiawan/echopype
that referenced
this pull request
Feb 27, 2023
… appending of path and list (OSOceanAcoustics#913) * Expand prov.source_files_vars to support path sequences that mix a str/path and another sequence; will add error checking * Enable source_files_vars to handle a sequence within a sequence * For EK80, ES70, ES80, EA640, conversion was inserting an unnecessary, empty meta_source_filenames variable * Add more comprehensive and readable prov source-files type hints; rename _source_files * Fix prov type hint bug with Py 3.8 * Add unit test for prov _sanitize_source_files; plus small fixes to np.ndarray type references in prov Co-authored-by: Emilio Mayorga <emiliomayorga@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redos PR #908. See #908 for all conversations.
This is part of the fix to ensure that we have a clean squash-and-merge history on
devand eventuallymain.