Redo: Add apply_mask function to mask sub-package
#912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and allow it to handle a DataArray input, modify existing tests for validate_source_ds
…s for the core method in apply_mask
… add associated test in test_apply_mask
… provided as a path
…ue)=DataArray conflict with xr.where
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
for more information, see https://pre-commit.ci
lsetiawan
pushed a commit
to lsetiawan/echopype
that referenced
this pull request
Feb 27, 2023
…cs#912) See OSOceanAcoustics#905 for all conversations and detailed commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redos PR #905. See #905 for all conversations.
This is part of the fix to ensure that we have a clean squash-and-merge history on
devand eventuallymain.