Add echopype working directory #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emiliom
reviewed
Dec 8, 2022
emiliom
reviewed
Dec 8, 2022
|
I like it. Granted, this new user folder would be hidden, so users would need to be made aware of it, say, to clean it up occasionally. But if the official temp space ( |
|
Two things that should follow from this:
|
Codecov Report
@@ Coverage Diff @@
## dev #896 +/- ##
===========================================
- Coverage 78.54% 20.18% -58.36%
===========================================
Files 53 53
Lines 5112 5117 +5
===========================================
- Hits 4015 1033 -2982
- Misses 1097 4084 +2987
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lsetiawan
added a commit
to lsetiawan/echopype
that referenced
this pull request
Feb 27, 2023
* Add echopype working directory * Update test var names * Fix .cleanup call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is an idea I had in regards to a hidden working directory for echopype. This directory can be used for any temp files/configs/helper files or sub directories, etc that we may need. It's hidden but can still be easily found in the user directory.