Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Parsing Invalid EK80 Environment Datagram(s) #1387

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

ctuguinay
Copy link
Collaborator

@ctuguinay ctuguinay commented Sep 3, 2024

Temporary fix for #1386

@ctuguinay ctuguinay added bug Something isn't working data conversion labels Sep 3, 2024
@ctuguinay ctuguinay added this to the v0.9.1 milestone Sep 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (9f56124) to head (afa1efb).
Report is 140 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
- Coverage   83.52%   80.22%   -3.31%     
==========================================
  Files          64       18      -46     
  Lines        5686     3089    -2597     
==========================================
- Hits         4749     2478    -2271     
+ Misses        937      611     -326     
Flag Coverage Δ
unittests 80.22% <100.00%> (-3.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctuguinay ctuguinay changed the title Skip Parsing Invalid EK80 Environment Datagram Skip Parsing Invalid EK80 Environment Datagram(s) Sep 3, 2024
@ctuguinay ctuguinay marked this pull request as ready for review September 3, 2024 17:45
@ctuguinay
Copy link
Collaborator Author

@leewujung This should be ready for review

Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some text for comments. Other than that, I think we can merge this.

Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
@ctuguinay
Copy link
Collaborator Author

@leewujung Thanks for the review! And yeah you're right, it's not a bug per se. I just added your suggestion.

@ctuguinay ctuguinay merged commit 63cdf95 into OSOceanAcoustics:main Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data conversion
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants