Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Temporarily skip datagrams generated by EC150 #1357

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

leewujung
Copy link
Member

@leewujung leewujung commented Jul 13, 2024

This PR includes changes to ParseEK to skip reading and saving datagrams generated by EC150 ADCP.

We can actually parse the echosounder-equivalent data fine, but we still need 2 other pieces to carry it to the next stage, so this is a "hotfix" to just skip these datagrams for now. The pieces we need are:

  • determine where to save the complex or power data: as a separate Beam_group3 or with the previous Beam_group1/2?
  • make sure calibration code can run through fine: not sure at the moment if all the necessary broadband calibration parameters are in place, but looks like all the necessary narrowband calibration parameters are there.

This PR still needs:

@leewujung leewujung added this to the v0.9.0 milestone Jul 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (9f56124) to head (b34f7bb).
Report is 123 commits behind head on main.

Files Patch % Lines
echopype/convert/parse_base.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1357      +/-   ##
==========================================
- Coverage   83.52%   78.87%   -4.65%     
==========================================
  Files          64       16      -48     
  Lines        5686     2708    -2978     
==========================================
- Hits         4749     2136    -2613     
+ Misses        937      572     -365     
Flag Coverage Δ
unittests 78.87% <90.90%> (-4.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leewujung leewujung marked this pull request as ready for review July 13, 2024 06:15
@leewujung leewujung requested a review from ctuguinay July 13, 2024 06:15
Copy link
Collaborator

@ctuguinay ctuguinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good, just commented out a print statement!

@ctuguinay ctuguinay merged commit d4cf8ea into OSOceanAcoustics:main Jul 15, 2024
5 checks passed
@leewujung leewujung deleted the skip_EC150 branch July 21, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants