Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the visualize subpackage #1336

Merged
merged 6 commits into from
Jun 15, 2024
Merged

Remove the visualize subpackage #1336

merged 6 commits into from
Jun 15, 2024

Conversation

leewujung
Copy link
Member

@leewujung leewujung commented Jun 15, 2024 •
edited
Loading

This addresses the second task in #1276:

  • remove the visualize package.
  • retain the EK500 colormap in the new colormap package
  • add simple test to make sure colormap is imported

Need another PR to update the visualization page in the docs.

@leewujung leewujung added this to the v0.9.0 milestone Jun 15, 2024
@leewujung leewujung requested a review from ctuguinay June 15, 2024 16:34
@leewujung leewujung mentioned this pull request Jun 15, 2024
Closed
ctuguinay
ctuguinay approved these changes Jun 15, 2024
View reviewed changes
Copy link
Collaborator

@ctuguinay ctuguinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It worked for me!

image

@leewujung leewujung merged commit 20e7599 into OSOceanAcoustics:main Jun 15, 2024
5 checks passed
@leewujung leewujung mentioned this pull request Jul 2, 2024
Closed
@leewujung leewujung deleted the rm_visualize branch July 21, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctuguinay ctuguinay ctuguinay approved these changes

Assignees
No one assigned
Labels
infrastructure
Projects
Echopype
Status: Done
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@leewujung @ctuguinay