Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Temporarily remove Python 3.11 [all tests ci] #1156

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

leewujung
Copy link
Member

This PR temporarily removes Python 3.11 testing and packaging until parsed2zarr overhaul is completed, which likely would either remove more_itertools as a dependency or unpin it (currently pinned to more_itertools=8.13.0).

@leewujung leewujung added this to the 0.8.1 milestone Sep 2, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023

Codecov Report

Merging #1156 (da9ddda) into dev (00ee579) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1156   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files          64       64           
  Lines        5803     5803           
=======================================
  Hits         4779     4779           
  Misses       1024     1024           
Flag Coverage Δ
unittests 82.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leewujung
Copy link
Member Author

Hey @lsetiawan : I am very puzzled by why in the "experimental" 3.11 testing runs tests like echopype/tests/convert/test_parsed_to_zarr.py::test_raw2zarr[noaa_offloaded] did not fail, but when 3.11 is tested for real, the same test would fail.

All of the failure is related to the use of more_itertools in the current parsed2zarr module. That library was pinned to 8.13.0, but the latest is already 10.1.0. I am hope in #1070 you can either completely remove this dependency or unpin it. For v0.8.1, I'll temporarily remove 3.11 just to be safe. Thanks!

@leewujung leewujung merged commit 09e2705 into OSOceanAcoustics:dev Sep 2, 2023
5 checks passed
@leewujung leewujung deleted the rm_py311 branch July 21, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants