Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EchoData examples in docs #1089

Merged
merged 8 commits into from
Aug 20, 2023

Conversation

leewujung
Copy link
Member

@leewujung leewujung commented Jul 25, 2023

This PR addresses #1054 by the following:

  • re-render EK60 example file using the latest version of echopype
  • add EK80 (2 examples) and AZFP example files

I'll wordsmith a bit after seeing the rendering outcome. Will mark this as ready for review when done.

@leewujung leewujung added the docs label Jul 25, 2023
@leewujung leewujung added this to the 0.8.0 milestone Jul 25, 2023
@leewujung leewujung requested a review from emiliom July 25, 2023 04:56
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@emiliom
Copy link
Collaborator

emiliom commented Jul 26, 2023

I suggest waiting until everything else is done and merged for this release, before merging the "final" version of this updated notebook document. There are additional EchoData changes rolling in for the upcoming release.

It'll be great to see those additional examples (EK80, AZFP) in the docs -- thanks!!

@leewujung leewujung marked this pull request as ready for review August 19, 2023 03:10
@leewujung
Copy link
Member Author

We need to re-run this notebook once we have v0.8.0 released, to update the statement in this notebook that uses ep.__version__ that therefore currently reads:

The echopype version used to render the EchoData objects below is: 0.7.2.dev50+g451d5ef6

@leewujung
Copy link
Member Author

I'll self-merge now so that I can continue to work on #1093.

@leewujung leewujung merged commit 7c0c818 into OSOceanAcoustics:dev Aug 20, 2023
3 checks passed
@leewujung leewujung deleted the echodata-render branch July 21, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants