Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct or add missing SONAR-netCDF4 variable attributes for AZFP #1023

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

emiliom
Copy link
Collaborator

@emiliom emiliom commented Apr 5, 2023

  • Add some missing variable attributes in "Sonar/Beam_group1" and "Platform" groups (eg, for backscatter_r, tilt_x, tilt_y)
  • Fix temperature variable attributes in "Environment" group; they were being assigned as dataset (global), not variable attributes

@emiliom emiliom added bug Something isn't working data format Anything about data format labels Apr 5, 2023
@emiliom emiliom added this to the 0.7.1 milestone Apr 5, 2023
@emiliom emiliom requested a review from leewujung April 5, 2023 20:33
@emiliom emiliom self-assigned this Apr 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #1023 (b4ec468) into dev (2736ee9) will decrease coverage by 2.94%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev    #1023      +/-   ##
==========================================
- Coverage   80.45%   77.51%   -2.94%     
==========================================
  Files          67       18      -49     
  Lines        6038     2869    -3169     
==========================================
- Hits         4858     2224    -2634     
+ Misses       1180      645     -535     
Flag Coverage Δ
unittests 77.51% <ø> (-2.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echopype/convert/set_groups_azfp.py 97.46% <ø> (ø)

... and 51 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emiliom : looks good, feel free to merge!

@emiliom emiliom merged commit 8abe18b into OSOceanAcoustics:dev Apr 6, 2023
@emiliom emiliom deleted the azfp-echodata-varattrs branch April 6, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data format Anything about data format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants