cs2cs / proj_create_crs_to_crs(): fix regression with geocentric CRS #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to use case of OSGeo/gdal#7753 When a transformation involved a datum shift with a grid and a geocentric CRS as source/target, since PROJ 9.2.0 and the changes for the only_best mode, even in just warning mode, if the grid of the "best" transformation was missing, then the transformation would completely fail, whereas with earlier versions it would fallback to a ballpark transformation. So restore that mode, and actually enhance the operation selection logic, by allowing to select operations based on their area of validity even if the input coordinate are geocentric (in which case a conversion of them to geographic is done).
rouault
force-pushed
the
crs_to_crs_geocentric_crs
branch
from
b30cf55
to
190bfb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to use case of OSGeo/gdal#7753
When a transformation involved a datum shift with a grid and a geocentric CRS as source/target, since PROJ 9.2.0 and the changes for the only_best mode, even in just warning mode, if the grid of the "best" transformation was missing, then the transformation would completely fail, whereas with earlier versions it would fallback to a ballpark transformation. So restore that mode, and actually enhance the operation selection logic, by allowing to select operations based on their area of validity even if the input coordinate are geocentric (in which case a conversion of them to geographic is done).