Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database covariate storage #153

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

azimov
Copy link

@azimov azimov commented Jan 13, 2022

Resolves PR #152 , storing results in DB rather than Andromeda object. Also fixes likely errors that occured before and allows specification to store timeRef and covariatesContinuous in database tables with newly specified targetTables list parameter.

@azimov azimov changed the base branch from master to develop January 14, 2022 17:23
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #153 (9bc11c9) into develop (fdfd9b7) will increase coverage by 72.47%.
The diff coverage is 96.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #153       +/-   ##
============================================
+ Coverage    23.28%   95.76%   +72.47%     
============================================
  Files           13       15        +2     
  Lines         1095     1157       +62     
============================================
+ Hits           255     1108      +853     
+ Misses         840       49      -791     
Impacted Files Coverage Δ
R/Aggregation.R 100.00% <ø> (+100.00%) ⬆️
R/FeatureExtraction.R 60.00% <ø> (+40.00%) ⬆️
R/GetCovariates.R 89.85% <ø> (+27.53%) ⬆️
R/Normalization.R 100.00% <ø> (+27.67%) ⬆️
R/CovariateData.R 88.15% <66.66%> (+78.69%) ⬆️
R/DefaultCovariateSettings.R 94.44% <66.66%> (+0.32%) ⬆️
R/DefaultTemporalCovariateSettings.R 94.44% <66.66%> (+0.32%) ⬆️
R/DefaultTemporalSequenceCovariateSettings.R 94.44% <94.44%> (ø)
R/UnitTestHelperFunctions.R 95.34% <95.34%> (ø)
R/CompareCohorts.R 95.06% <100.00%> (+95.06%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5363f5f...9bc11c9. Read the comment docs.

@anthonysena anthonysena modified the milestone: v4.0.0 Jun 20, 2022
@anthonysena
Copy link
Collaborator

@azimov - could you merge in the latest code on develop to this branch and resolve any conflicts? Then @ginberg and I will take a look. Thanks!

@anthonysena anthonysena self-assigned this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storing aggregate covariate data in RDBMS server instead of Andromeda
2 participants