Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing aggregate covariate data in RDBMS server instead of Andromeda #152

Open
azimov opened this issue Jan 11, 2022 · 0 comments · May be fixed by #153
Open

Storing aggregate covariate data in RDBMS server instead of Andromeda #152

azimov opened this issue Jan 11, 2022 · 0 comments · May be fixed by #153
Assignees
Milestone

Comments

@azimov
Copy link

azimov commented Jan 11, 2022

Currently it appears that the use of an RDBMS is supported [for storing computed features] in getDbDefaultCovariateData(

# Don't fetch to R , but create on server instead
), however it appears that this is not possible for aggregate features.

When performing feature extraction on around 1000+ cohorts, storing the aggregate features in andromeda objects on disk becomes more difficult with the size of the features.

It also looks like the code for getDbDefaultCovariateData doesn't function correctly for the non-aggreagate features as there is a discrepancy between the executed SQL statements here and here.

To store results in a new table will also probably break in the case where the tables already exist, so and overwriteTables flag should be included.

@azimov azimov self-assigned this Jan 11, 2022
@azimov azimov linked a pull request Jan 13, 2022 that will close this issue
@anthonysena anthonysena added this to the v4.0.0 milestone Jun 20, 2022
@anthonysena anthonysena linked a pull request Jan 10, 2023 that will close this issue
@anthonysena anthonysena modified the milestones: v4.0.0, V3.5.0 Feb 16, 2024
@ginberg ginberg modified the milestones: V3.5.0, v3.6.0 Apr 18, 2024
@ginberg ginberg modified the milestones: v3.6.0, v3.7.0 Jun 4, 2024
@anthonysena anthonysena modified the milestones: v3.6.0, v3.7.0 Jun 7, 2024
@ginberg ginberg modified the milestones: v3.7.0, v4.0.0 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants