[16.0][IMP] stock_available_immediately_exclude_location: Deducte the quants in excluded locations for free_qty of products #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in excluded locations for free_qty of products
sebalix
reviewed
Jul 9, 2024
Comment on lines
15
to
18
| """ | ||
| change the way immediately_usable_qty is computed by deducing the quants | ||
| Re-compute the the `free to use` qty by deducting the quants | ||
| in excluded locations | ||
| """ |
There was a problem hiding this comment.
Better to not override the original docstring of the method and to write this as a comment instead
Comment on lines
+35
to
+38
| """ | ||
| change the way immediately_usable_qty is computed by deducting the quants | ||
| in excluded locations | ||
| """ |
There was a problem hiding this comment.
Same remark (the docstring was already there but better to fix it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
free_qty_todaycomes fromfree_qtyfield of product (It is computed from here)exclude_from_immediately_usable_qty: hereChanges:
_compute_quantities_dictto avoid making recursive in methodfree_qtyby deducting the qty in excluded locationsResult: (
Forecasted qtyandAvailable qty)