Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] [MIG] stock_available_mrp: Migration to 17.0 #24

Draft
wants to merge 68 commits into
base: 17.0
Choose a base branch
from
Draft

[17.0] [MIG] stock_available_mrp: Migration to 17.0 #24

wants to merge 68 commits into from

Conversation

bizzappdev
Copy link

No description provided.

sbidoul and others added 30 commits May 10, 2024 10:57
@sbidoul @bizzappdev
[MOV] move addons out of __unported__ (they remain not installable)
acaf775
@bizzappdev
[MIGR] stock_available_mrp: migrate to v8
f6e38b6 
Compute potential quantities for both product templates and variants. To keep the code simple, only the biggest potential of any single variant is accounted for in the template's potential.
Take all levels of phantom BoM into account, respects validity dates etc. thanks to the use of the standard method _bom_explode, as suggested by @gdgellatly in OCA/stock-logistics-warehouse#5 (comment)
Improve tests, rewritten in python.
Adhere to new file/manifest/README conventions.
Simplify copyright headers
@lmignon @bizzappdev
[FIX] Browse mrp.bom as current user
65f0202 
sudo is not required since mrp.bom are readable to groups with access to the qty_x fields on a product. Moreover using sudo to retrive the bom will ignore the company_id defined on the bom
@bizzappdev
[FIX] fix multi-company test
3ebc7cc 
Record rules used to not be checked on stock quants, but now they are since Odoo's commit 2fd14db57433d08ab368a7e18d18ae8d49dafab1 (odoo/odoo@2fd14db).
In our test we changed the company of the products and BoMs but we neglected that the stock was not attached to the right company, and that made the test fail.
To fix that, make the test inventory for the right company.
Since there is a little inconsistency in the demo data with a negative quantity of an unrelated product, use the `partial` filter for the inventories instead of the `none` filter, so that no wrong inventory lines are added automatically.
@oca-transbot @bizzappdev
OCA Transbot updated translations from Transifex
2aaf549
@bizzappdev
stock_available_mrp: fix BOM qty (multi-units, efficiency)
c1b72c5
@bizzappdev
stock_available / stock_available_mrp : add possibility to choose whi…
5275ac5 
…ch field use to compute potential
@bizzappdev
[FIX+IMP] stock_available_mrp: fix recursive potential_qty in list vi…
fd70ef6 
…ew + small improvements
@bizzappdev
V9 migration modifications.
2bcb8cb 
    * mrp_bom.name has been deleted.
    * mrp_bom_line.type moved to mrp_bom.type.
    * Fix missing group_mrp_user issue.
    * Change versions
@oca-transbot @bizzappdev
OCA Transbot updated translations from Transifex
973bce6
@bizzappdev
[10.0][MIG] port stock_available_mrp to 10.0
0ecaf28
@rousseldenis @bizzappdev
[IMP] stock_available_mrp: readability + change compute bom_id + use …
db64ca8 
…recordset + Condition never statisfied
@bizzappdev
[ADD] include new improvments
cb62ed6
@bizzappdev
[FIX] stock_available_mrp: remove duplicate button + fix calculation …
d341687 
…of immediately usable qty
@bizzappdev
[11.0][MIG] port stock_available_mrp to 11.0
2d3e60d
@florian-dacosta @bizzappdev
Migrate stock_available_mrp to v12
3c1ec1d
@florian-dacosta @bizzappdev
Make stock_available_mrp compatible with other modules like stock_ava…
fc056b2 
…ilable_immediately
@pedrobaeza @bizzappdev
[FIX] stock_available_mrp: Fix RST formatting + generate README
28c54ae
@oca-travis @bizzappdev
[UPD] Update stock_available_mrp.pot
4ee8fd1
@oca-transbot @bizzappdev
Update translation files
5234037 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_mrp/
@oca-transbot @bizzappdev
Update translation files
0429c88 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_mrp/
@liweijie0812 @bizzappdev
Translated using Weblate (Chinese (Simplified))
e9ba303 
Currently translated at 100.0% (7 of 7 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_mrp/zh_CN/
@ypapouin @bizzappdev
Translated using Weblate (French)
23b8938 
Currently translated at 100.0% (7 of 7 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_mrp/fr/
@chienandalu @bizzappdev
[FIX] stock_available_mrp: upstream compatibility
292bdb4 
After this change odoo/odoo@3d34d58
it isn't possible to have an storable kit product anymore. The main
issue is that we have to drop some uses cases that this module
considered for this kind of situations.
@OCA-git-bot @bizzappdev
stock_available_mrp 12.0.1.0.1
bb08524
@chienandalu @bizzappdev
[FIX] stock_available_mrp: don't force type
8490935 
In Odoo change odoo/odoo@3d34d58 the products with Kit BoMs couldn't
longer be other than `consu`. This was reverted in odoo/odoo@6c4623a
and some products are raising errors when forcing the type
@OCA-git-bot @bizzappdev
stock_available_mrp 12.0.1.0.2
176287f
@victoralmau @bizzappdev
[IMP] stock_available_mrp: black, isort, prettier
e5747f5
@victoralmau @bizzappdev
[MIG] stock_available_mrp: Migration to 13.0
f91c5bd
@oca-travis @bizzappdev
[UPD] Update stock_available_mrp.pot
fde2553
Cédric Pigeon and others added 23 commits May 10, 2024 10:57
@bizzappdev
[14.0] stock_available: improve search performance
4777da4
@oca-travis @bizzappdev
[UPD] Update stock_available_mrp.pot
b52995a
@OCA-git-bot @bizzappdev
stock_available_mrp 14.0.1.0.3
3cea0bc
@oca-transbot @bizzappdev
Update translation files
8aa55f5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_available_mrp/
@JoanMForgeFlow @bizzappdev
[15.0][IMP] stock_available_mrp: black, isort, prettier
7846fac
@JoanMForgeFlow @bizzappdev
[15.0][MIG] stock_available_mrp: Migration to 15.0
18839f8
@bizzappdev
[UPD] Update stock_available_mrp.pot
2d935a1
@OCA-git-bot @bizzappdev
[UPD] README.rst
9b2c862
@victoralmau @bizzappdev
[FIX] stock_available_mrp: Set correctlly immediately_usable_qty value.
fcdd391 
TT27873
@rousseldenis @bizzappdev
[TESTS] stock_available_mrp: Add test for phantom bom
55baeff
@OCA-git-bot @bizzappdev
stock_available_mrp 15.0.1.0.1
054cac5
@jabelchi @bizzappdev
Added translation using Weblate (Catalan)
2dfc378
@jabelchi @bizzappdev
Translated using Weblate (Catalan)
02f52dc 
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_available_mrp/ca/
@khoivo1601 @bizzappdev
[16.0][MIG] stock_available_mrp: Migration to 16.0
a870ae2
@bizzappdev
[UPD] Update stock_available_mrp.pot
702c32c
@OCA-git-bot @bizzappdev
[UPD] README.rst
67b89ce
@OCA-git-bot @bizzappdev
[UPD] README.rst
bb84cef
@Ivorra78 @bizzappdev
Translated using Weblate (Spanish)
0715ba9 
Currently translated at 100.0% (10 of 10 strings)

Translation: stock-logistics-availability-16.0/stock-logistics-availability-16.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-availability-16-0/stock-logistics-availability-16-0-stock_available_mrp/es/
@weblate @bizzappdev
Update translation files
47468d4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-availability-16.0/stock-logistics-availability-16.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-availability-16-0/stock-logistics-availability-16-0-stock_available_mrp/
@Ivorra78 @bizzappdev
Translated using Weblate (Spanish)
b95ca26 
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-availability-16.0/stock-logistics-availability-16.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-availability-16-0/stock-logistics-availability-16-0-stock_available_mrp/es/
@mymage @bizzappdev
Translated using Weblate (Italian)
04cbbba 
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-availability-16.0/stock-logistics-availability-16.0-stock_available_mrp
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-availability-16-0/stock-logistics-availability-16-0-stock_available_mrp/it/
@bizzappdev
[IMP] stock_available_mrp: pre-commit auto fixes
ec30c72
@bizzappdev
[MIG] stock_available_mrp: Migration to 17.0
f803099
@bizzappdev bizzappdev force-pushed the 17.0-mig-stock_available_mrp-BAD branch from cbccdab to f803099 Compare May 20, 2024 12:08
@bizzappdev bizzappdev marked this pull request as ready for review May 20, 2024 14:48
@rpinset rpinset mentioned this pull request Jun 28, 2024
Open
6 tasks
@rpinset
Copy link
Member

rpinset commented Jun 28, 2024

hello @bizzappdev
I tested your branch and offer you a fix in order to correctly recover the ir.config.parameter
BizzAppDev-Systems#1

Couldn't there be a calculation problem?
The immediately_usable_qty field only gives the potential quantity.
image

Shouldn't this be "stock in hand + potential_qty" in order to have our stock of finished product already available increased by that which can be manufactured?

@bizzappdev
Copy link
Author

@rpinset thank you for the review, and MR
IMO, your proposed MR is a partial fix, which will create a problem for the Migrated database problem.
But for sure, a fix is needed.
Right now, we have a bug in the migration script, which we will have to fix.
Soon, we will do the new fix commit.

@bizzappdev bizzappdev marked this pull request as draft June 28, 2024 10:53
@rpinset
Copy link
Member

rpinset commented Jun 28, 2024

BizzAppDev-Systems#2

this is a suggestion to modify the migration script
because if the key is not stock_available_mrp.stock_available_mrp_based_on then the calculation is not done according to the desired config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.