[IMP] queue_job: Add split method

[paradoxxxzero]

This is a draft PR trying an alternative approach for #566

  class ResPartner(models.Model):
      # ...

      def copy_all_partners(self):
          # Duplicate all partners in batches of 30:
          self.with_delay(split=30).copy()

    # or

     def copy_all_partners(self):
          # Duplicate all partners in batches of 30:
          self.delayable().set(description='Copy Partners').copy().split(30).delay()

  # ...
  self.env['res.partner'].search([], limit=1000).copy_all_partners()

The split function on Delayable returns a DelayableGroup.

This is an attempt and I am open to suggestions

[OCA-git-bot]

Hi @guewen,
some modules you are maintaining are being modified, check this out!

[amh-mw]

For a division without remainder, won't this return one too many?

[paradoxxxzero]

Yes, indeed. I have rewritten the loop and added some tests.

[amh-mw]

Perhaps simpler to let range do more of the work?

for start in range(0, total_records, size):

[paradoxxxzero]

Good idea

[amh-mw]

Is this necessary? Couldn't a developer just call delayable.split() themselves?

[paradoxxxzero]

Removed

[amh-mw]

LGTM

[paradoxxxzero]

The coverage does not seem to include the unittest :/

[amh-mw]

The coverage does not seem to include the unittest :/

Import the new test in tests/__init__.py

[paradoxxxzero]

They weren't run as they were unitest.TestCase, I changed them to TransactionCase for odoo to run them.

[paradoxxxzero]

I added a chain parameter to split into a chain instead of a group.

Is there anything lacking for this to be merged?

[amh-mw]

Is there anything lacking for this to be merged?

Just the attention of @OCA/connector-maintainers

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[simahawk]

Nice, thanks! Just some minor remarks :)

@guewen ping :)

[simahawk]

There's no transaction required here. Use TestCase or BaseCase

[simahawk]

same regarding the base class

[simahawk]

Suggested change

	"""Split the Delayable into a DelayableGroup or DelayableChain
	if `chain` is True containing batches of size `size`
	"""
	"""Split the Delayables.
	Use `DelayableGroup` or `DelayableChain`
	if `chain` is True containing batches of size `size`
	"""