[FIX] make the module working for product variants #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinDupont
approved these changes
Mar 19, 2018
pedrobaeza
requested changes
Mar 19, 2018
| def onchange_uom(self, uom_id, uom_po_id): | ||
| res = super(ProductProduct, self).onchange_uom(uom_id, uom_po_id) | ||
| if uom_id: | ||
| res = res and res or {} |
There was a problem hiding this comment.
It's enough with res = res or {}
| res = super(ProductProduct, self).onchange_uom(uom_id, uom_po_id) | ||
| if uom_id: | ||
| res = res and res or {} | ||
| if not res.get('value', False): |
There was a problem hiding this comment.
You can use val = res.setdefault('value', {}) and then val['to_weight'] = ...
|
@pedrobaeza. Thanks for your suggestion. modifications done. |
pedrobaeza
reviewed
Mar 19, 2018
| if res.get('value', False): | ||
| res['value']['to_weight'] =\ | ||
| self.env['product.uom'].browse(uom_id).to_weigh | ||
| res = res and res or {} |
legalsylvain
added a commit
to grap/pos
that referenced
this pull request
Jul 15, 2018
legalsylvain
added a commit
to legalsylvain/pos
that referenced
this pull request
Jul 7, 2019
legalsylvain
added a commit
to grap/pos
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to bad design in odoo 8.0 (not refactored in new API in 8.0), the onchange function should be defined in both models (product.product and product.template).