[16.0][MIG] operating_unit: migration to 16.0 #576

huguesdk · 2023-03-17T15:06:52Z

No description provided.

…per the OCA guidelines.

…uggestions.

* [MIG] operating_unit to v10.0

…er models

…ment

…ronments

huguesdk · 2023-03-17T15:13:03Z

/ocabot migration operating_unit

OCA-git-bot · 2023-03-17T15:13:13Z

Sorry @huguesdk you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

alan196

👍 Technical review

AaronHForgeFlow · 2023-03-21T17:08:38Z

/ocabot migration operating_unit

AaronHForgeFlow

Functional review. I can remove operating unit for users except for the admin, If I remove the operating unit for the admin and I jump out and jump in again the user form view of the admin I see all OUs are assigned. Can't remove. Could you check that?

houssine78 · 2023-03-30T13:41:14Z

Hi @huguesdk, did you see the comment from Aaron ? Does it needs action from your side ? It's an improvement or this should work as the Aaron's expectations ?

Thank you :)

huguesdk · 2023-03-31T08:14:49Z

hi @houssine78. yes, i saw the comment, but thanks for the heads up! i did not intend to change the behavior, so if it does not work as in 15.0, then i need to fix it.

@AaronHForgeFlow: thanks for the review! do you know if this is something that works as expected in 15.0?

gurneyalex · 2023-04-11T17:44:32Z

operating_unit/models/operating_unit.py

@@ -41,22 +42,6 @@ class OperatingUnit(models.Model):
        ),
    ]

-    @api.model
-    def name_search(self, name="", args=None, operator="ilike", limit=100):


is there a reason for the removal of the name_search method?

yes, it is because the new _rec_names_search class variable now allows for the same behavior without the need to define .name_search(). see the guide to migrate to 16.0.

OCA-git-bot · 2023-04-11T18:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

huguesdk · 2023-04-11T21:40:05Z

Functional review. I can remove operating unit for users except for the admin, If I remove the operating unit for the admin and I jump out and jump in again the user form view of the admin I see all OUs are assigned. Can't remove. Could you check that?

@AaronHForgeFlow: i tested in 15.0 and the behavior is the same. it comes from this code, which forces the users belonging to the operating_unit.group_manager_operating_unit group to have all operating units linked to them.

AaronHForgeFlow · 2023-04-12T07:31:10Z

Thanks for checking @huguesdk I think that is ok then. I just won't assign users to that group when they don't have access to all OU.

AaronHForgeFlow · 2023-04-12T07:33:57Z

/ocabot merge nobump

OCA-git-bot · 2023-04-12T09:11:00Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-576-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2023-04-12T09:15:27Z

Congratulations, your PR was merged at 60ca2d0. Thanks a lot for contributing to OCA. ❤️

sudhir-serpentcs and others added 30 commits March 17, 2023 13:48

[ADD] Added migrated Operating Unit module for v9.

83e51fe

[IMP] Improved the license terms and improved the module standard as …

4073a7e

…per the OCA guidelines.

[ADD] Renamed README.md to README.rst

117a0ed

[IMP] Assign multi_ou grup and add OCA logo.

e4d13f5

[FIX] remove description from __openerp__.py

213d404

[FIX] Corrections as per review comments

4cd549b

[ADD] Added travis yml file and changed the code as per travis test s…

b6b495e

…uggestions.

[IMP] Added name_search to search the OU based on name and code.

b24a2c8

[FIX] Review as per @dreispt comments

15bdec0

[FIX] Review as per travis

f3277af

[FIX] flake8

a523bdb

[IMP] improve name_search

9e84247

[IMP] changed readme.rst

24326b5

[IMP] changed Eficent copyright

1968885

[IMP] removed size from char fields. General improvement to XML style.

229a48c

[MIG] Make modules uninstallable

bdbfe9c

[MIG] Rename manifest files

95f82ac

[MIG] operating_unit to v10.0 (OCA#45)

f5d3774

* [MIG] operating_unit to v10.0

A user can only select the operating units that he is allowed (OCA#59)

673adb4

Port to v11 - retry

160da9c

[12.0][MIG] operating_unit: Migration to v12.0

a143783

[UPD] README.rst

0c5fdbd

[IMP]add user_ids field in operating unit. Useful for accesing in oth…

fd2cb7f

…er models

[UPT]operating_unit roadmap

3676487

[UPD] README.rst

135e3f4

[FIX] operating_unit: Failing test

47118a1

[FIX] operating_unit: Creation of OU's failing cause of wrong environ…

6f6faa6

…ment

[FIX]clear caches when saving so OU rules are updated

20b0cc7

[FIX] Make company_id readonly to avoid crashes in multi-company envi…

fe1e676

…ronments

[UPD] README.rst

dbb82ce

sswapnesh and others added 4 commits March 17, 2023 13:48

[FIX] operating_unit: correctly assign operating_unit_ids

ebbc12b

[FIX] operating_unit: minor fix in test

bb066b1

operating_unit 15.0.1.0.6

69d26dd

[MIG] operating_unit: migration to 16.0

a94a0aa

huguesdk force-pushed the 16.0-mig-operating_unit branch from 5d4d1c4 to a94a0aa Compare March 17, 2023 15:16

huguesdk mentioned this pull request Mar 17, 2023

[16.0][MIG] project_operating_unit: migration to 16.0 #578

Merged

alan196 approved these changes Mar 21, 2023

View reviewed changes

OCA-git-bot added this to the 16.0 milestone Mar 21, 2023

OCA-git-bot mentioned this pull request Mar 21, 2023

Migration to version 16.0 #509

Open

10 tasks

AaronHForgeFlow reviewed Mar 21, 2023

View reviewed changes

gurneyalex reviewed Apr 11, 2023

View reviewed changes

gurneyalex approved these changes Apr 11, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 11, 2023

AaronHForgeFlow approved these changes Apr 12, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Apr 12, 2023

OCA-git-bot merged commit 840a02a into OCA:16.0 Apr 12, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] operating_unit: migration to 16.0 #576

[16.0][MIG] operating_unit: migration to 16.0 #576

huguesdk commented Mar 17, 2023

huguesdk commented Mar 17, 2023

OCA-git-bot commented Mar 17, 2023

alan196 left a comment

AaronHForgeFlow commented Mar 21, 2023

AaronHForgeFlow left a comment •

edited

Loading

houssine78 commented Mar 30, 2023

huguesdk commented Mar 31, 2023

gurneyalex Apr 11, 2023

huguesdk Apr 11, 2023 •

edited

Loading

OCA-git-bot commented Apr 11, 2023

huguesdk commented Apr 11, 2023

AaronHForgeFlow commented Apr 12, 2023

AaronHForgeFlow commented Apr 12, 2023

OCA-git-bot commented Apr 12, 2023

OCA-git-bot commented Apr 12, 2023

[16.0][MIG] operating_unit: migration to 16.0 #576

[16.0][MIG] operating_unit: migration to 16.0 #576

Conversation

huguesdk commented Mar 17, 2023

huguesdk commented Mar 17, 2023

OCA-git-bot commented Mar 17, 2023

alan196 left a comment

Choose a reason for hiding this comment

AaronHForgeFlow commented Mar 21, 2023

AaronHForgeFlow left a comment • edited Loading

Choose a reason for hiding this comment

houssine78 commented Mar 30, 2023

huguesdk commented Mar 31, 2023

gurneyalex Apr 11, 2023

Choose a reason for hiding this comment

huguesdk Apr 11, 2023 • edited Loading

Choose a reason for hiding this comment

OCA-git-bot commented Apr 11, 2023

huguesdk commented Apr 11, 2023

AaronHForgeFlow commented Apr 12, 2023

AaronHForgeFlow commented Apr 12, 2023

OCA-git-bot commented Apr 12, 2023

OCA-git-bot commented Apr 12, 2023

AaronHForgeFlow left a comment •

edited

Loading

huguesdk Apr 11, 2023 •

edited

Loading