Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_nl_partner_name: Migration to 16.0 #418

Open
wants to merge 27 commits into
base: 16.0
Choose a base branch
from

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jul 22, 2024

No description provided.

hbrunn and others added 16 commits July 22, 2024 07:59
from 8.0 to 10.0

[MIG] Migrates l10n_nl_partner_salutation from 8.0 to 10.0

Adding a commiter, changing the format of the licence comment, removing deprecated Char init variable

[FIX] Sort version of licencing, removing VIM comments, changing __openerp__ to __manifest__

[FIX] Adding tests to increase code coverage

[FIX] Replaces api.one with api.multi and inserting api.model

[FIX] Adds newlines on the xmls, adds licence on manifest, changes name of compute methods

[FIX] Creates the res_partner_title_sir in the module instead on the base module
* [DEL] obsolete manifest

* [IMP] allow to fill in names in a more natural way
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-netherlands-11.0/l10n-netherlands-11.0-l10n_nl_partner_name
Translate-URL: https://translation.odoo-community.org/projects/l10n-netherlands-11-0/l10n-netherlands-11-0-l10n_nl_partner_name/
@hbrunn hbrunn force-pushed the 16.0-mig-l10n_nl_partner_name branch 2 times, most recently from 016869d to 8d2be30 Compare July 22, 2024 16:09
"""Extend res.partner with extra fields for Dutch names."""

_inherit = "res.partner"
_l10n_nl_partner_name_infixes = ("van", "der", "den", "op", "ter", "de", "v/d")
Copy link

@gjotten gjotten Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbrunn just curious since I've never used this module before personally, but if we use non-defined infixes like d', 't or te, the helper method below is not going to split names up correctly, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly. Any other ones I should add?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wiki page contains a curated summary, as well as a a link to a 12-page list provided by the Interior Ministry.

Looks like the latter should be handled in a reference file if push comes to shove 🙁

Copy link
Member Author

@hbrunn hbrunn Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the easy way out, added your proposals to the default and made the whole thing configurable. Please review the readme part about that for non-nerd compatibility

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme explanation LGTM

@bosd
Copy link
Contributor

bosd commented Oct 1, 2024

@hbrunn Can you please retrigger runboat creation??

@hbrunn hbrunn force-pushed the 16.0-mig-l10n_nl_partner_name branch from 1ace91c to 31b33a0 Compare October 1, 2024 10:55
@hbrunn
Copy link
Member Author

hbrunn commented Oct 1, 2024

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants