-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added changes for fixing the font and indentation issues. #54
Conversation
Added probable changes to fix the indentation issue too. #51 |
Thanks @saptarsi96 ! Could you add a screenshot? |
bosc.php
Outdated
@@ -12,7 +12,9 @@ | |||
|
|||
|
|||
<?php if ( have_posts() ) : while ( have_posts() ) : the_post(); ?> | |||
<?php the_content(); ?> | |||
<h5 style="color:black;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saptarsi96 Thanks for making this change :) Could we have the styling in the css files instead of inline? Let me know if you're having trouble finding the right rule to override the styling on this element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The css changes for h5 tag is done globally. That's why I thought it would be better if we can update only this local block of code which will fix the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm - how about adding a class for this?
updated as per requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yochannah Can you please review this change?
@hzahroh no rush but if you want you can take a look at this some time. |
Hi Nomi, I couldn’t find the issue #54
…On 25 Jan 2022 01.25 +0700, Nomi Harris ***@***.***>, wrote:
@hzahroh no rush but if you want you can take a look at this some time.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
It's a PR, not an issue, and I'm not sure whether it would in fact fix the problem. The URL for the PR is |
Closing this as out of date. |
This fix will resolve the issues reported by #49