Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes for fixing the font and indentation issues. #54

Closed
wants to merge 3 commits into from
Closed

Added changes for fixing the font and indentation issues. #54

wants to merge 3 commits into from

Conversation

saptarsi96
Copy link

This fix will resolve the issues reported by #49

@saptarsi96
Copy link
Author

Added probable changes to fix the indentation issue too. #51

@saptarsi96 saptarsi96 changed the title Added changes for fixing the font issue. Added changes for fixing the font and indentation issues. #49 #51 Oct 13, 2020
@saptarsi96 saptarsi96 changed the title Added changes for fixing the font and indentation issues. #49 #51 Added changes for fixing the font and indentation issues. Oct 13, 2020
@yochannah
Copy link
Member

Thanks @saptarsi96 ! Could you add a screenshot?

bosc.php Outdated
@@ -12,7 +12,9 @@


<?php if ( have_posts() ) : while ( have_posts() ) : the_post(); ?>
<?php the_content(); ?>
<h5 style="color:black;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saptarsi96 Thanks for making this change :) Could we have the styling in the css files instead of inline? Let me know if you're having trouble finding the right rule to override the styling on this element.

Copy link
Author

@saptarsi96 saptarsi96 Oct 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The css changes for h5 tag is done globally. That's why I thought it would be better if we can update only this local block of code which will fix the issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm - how about adding a class for this?

updated as per requirements.
Copy link
Author

@saptarsi96 saptarsi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yochannah Can you please review this change?

@nlharris
Copy link
Member

@hzahroh no rush but if you want you can take a look at this some time.

@hzahroh
Copy link
Member

hzahroh commented Jan 28, 2022 via email

@nlharris
Copy link
Member

nlharris commented Jan 28, 2022

It's a PR, not an issue, and I'm not sure whether it would in fact fix the problem. The URL for the PR is
https://github.com/OBF/homepage/pull/54

@yochannah
Copy link
Member

Closing this as out of date.

@yochannah yochannah closed this Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants