Skip to content

Commit

Permalink
Upgrade to react 16.9 in dev to prevent act warning in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Nurumoto committed May 13, 2019
1 parent 43a3995 commit d8ea3ab
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 26 deletions.
3 changes: 0 additions & 3 deletions __tests__/Drag.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import 'jest-dom/extend-expect'
import Interactive from './components/Interactive'
import InteractiveDom from './components/InteractiveDom'

// TODO - fix act warning (probably caused by RAF in cancel)
// https://github.com/facebook/react/issues/14769

// TODO - test drag with touch events
// TODO - test with pointerEvents

Expand Down
3 changes: 0 additions & 3 deletions __tests__/Move.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import InteractiveDom from './components/InteractiveDom'

afterAll(cleanup)

// TODO - fix act warning (probably caused by debounce)
// https://github.com/facebook/react/issues/14769

describe.each([['attached to component', Interactive, false], ['attached to node', InteractiveDom, true]])(
'testing onMove %s)',
(testName, Component, domTarget) => {
Expand Down
3 changes: 0 additions & 3 deletions __tests__/Scroll.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import 'jest-dom/extend-expect'
import Interactive from './components/Interactive'
import InteractiveDom from './components/InteractiveDom'

// TODO - fix act warning (probably caused by debounce)
// https://github.com/facebook/react/issues/14769

afterAll(cleanup)

describe.each([['attached to component', Interactive, false], ['attached to node', InteractiveDom, true]])(
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"build": "rollup -c",
"prepare": "npm run build",
"test": "jest",
"test:watch": "jest --watch --silent",
"test:watch": "jest --watch",
"test:coverage": "jest --coverage --silent",
"dtslint": "dtslint types"
},
Expand Down Expand Up @@ -67,8 +67,8 @@
"jest-dom": "^3.1.3",
"prettier": "^1.16.4",
"pretty-quick": "^1.10.0",
"react": "^16.8.0",
"react-dom": "^16.8.0",
"react": "^16.9.0-alpha.0",
"react-dom": "^16.9.0-alpha.0",
"react-testing-library": "^7.0.0",
"rimraf": "^2.6.2",
"rollup": "^1.10.0",
Expand Down
28 changes: 14 additions & 14 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4227,15 +4227,15 @@ rc@^1.2.7:
minimist "^1.2.0"
strip-json-comments "~2.0.1"

react-dom@^16.8.0:
version "16.8.6"
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-16.8.6.tgz#71d6303f631e8b0097f56165ef608f051ff6e10f"
integrity sha512-1nL7PIq9LTL3fthPqwkvr2zY7phIPjYrT0jp4HjyEQrEROnw4dG41VVwi/wfoCneoleqrNX7iAD+pXebJZwrwA==
react-dom@^16.9.0-alpha.0:
version "16.9.0-alpha.0"
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-16.9.0-alpha.0.tgz#9dfaec18ac1a500fa72cab7b70f2ae29d0cd7716"
integrity sha512-BQ5gN42yIPuTnBvE6K9vSjNfDRpSNcYCs2sUx9XR5VaWKwlHTt3G6qIWK6zdXy8TYKb1+IxpsAI0RtbRdXQZ2A==
dependencies:
loose-envify "^1.1.0"
object-assign "^4.1.1"
prop-types "^15.6.2"
scheduler "^0.13.6"
scheduler "^0.14.0-alpha.0"

react-is@^16.8.1, react-is@^16.8.4:
version "16.8.6"
Expand All @@ -4250,15 +4250,15 @@ react-testing-library@^7.0.0:
"@babel/runtime" "^7.4.3"
dom-testing-library "^4.0.0"

react@^16.8.0:
version "16.8.6"
resolved "https://registry.yarnpkg.com/react/-/react-16.8.6.tgz#ad6c3a9614fd3a4e9ef51117f54d888da01f2bbe"
integrity sha512-pC0uMkhLaHm11ZSJULfOBqV4tIZkx87ZLvbbQYunNixAAvjnC+snJCg0XQXn9VIsttVsbZP/H/ewzgsd5fxKXw==
react@^16.9.0-alpha.0:
version "16.9.0-alpha.0"
resolved "https://registry.yarnpkg.com/react/-/react-16.9.0-alpha.0.tgz#e350f3d8af36e3251079cbc90d304620e2f78ccb"
integrity sha512-y4bu7rJvtnPPsIwOj7sp5Y2SqlOb0jFupfkdjWxxn8ZeqzUARgpR9wJBUVwW1/QosVdOblmApjo/j6iiAXnebA==
dependencies:
loose-envify "^1.1.0"
object-assign "^4.1.1"
prop-types "^15.6.2"
scheduler "^0.13.6"
scheduler "^0.14.0-alpha.0"

read-pkg-up@^2.0.0:
version "2.0.0"
Expand Down Expand Up @@ -4610,10 +4610,10 @@ sax@^1.2.4:
resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.4.tgz#2816234e2378bddc4e5354fab5caa895df7100d9"
integrity sha512-NqVDv9TpANUjFm0N8uM5GxL36UgKi9/atZw+x7YFnQ8ckwFGKrl4xX4yWtrey3UJm5nP1kUbnYgLopqWNSRhWw==

scheduler@^0.13.6:
version "0.13.6"
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.13.6.tgz#466a4ec332467b31a91b9bf74e5347072e4cd889"
integrity sha512-IWnObHt413ucAYKsD9J1QShUKkbKLQQHdxRyw73sw4FN26iWr3DY/H34xGPe4nmL1DwXyWmSWmMrA9TfQbE/XQ==
scheduler@^0.14.0-alpha.0:
version "0.14.0"
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.14.0.tgz#b392c23c9c14bfa2933d4740ad5603cc0d59ea5b"
integrity sha512-9CgbS06Kki2f4R9FjLSITjZo5BZxPsryiRNyL3LpvrM9WxcVmhlqAOc9E+KQbeI2nqej4JIIbOsfdL51cNb4Iw==
dependencies:
loose-envify "^1.1.0"
object-assign "^4.1.1"
Expand Down

0 comments on commit d8ea3ab

Please sign in to comment.