Fix accessibility issue - role required when aria-expanded attribute is used #9445
Conversation
| @@ -577,7 +577,7 @@ var hlp = new AccordionHelper(name, formModelStatePrefix, expanded, page); | |||
| </div> | |||
| if (!disabled) | |||
| { | |||
| <div class="panel panel-default panel-collapse collapse @(expanded ? "in" : string.Empty)" | |||
| <div role="form" class="panel panel-default panel-collapse collapse @(expanded ? "in" : string.Empty)" | |||
There was a problem hiding this comment.
This is for ALL expandable sections (seeing it's a ViewHelpers) right? Are all expandable sections truly forms?
There was a problem hiding this comment.
That's a good point, I don't believe they are all forms. Unfortunately, aria-expanded attribute can only be used in a handful of roles. The sections that this div element are used for vary significantly as far as I can tell. The roles that the aria-expanded attribute can be used for are listed here. Any thoughts on this matter would be appreciated @joelverhagen @ryuyu
|
Addressed the issue pointed out by @joelverhagen. New fix is actually to remove the use of the |
Addresses #9415
Add a role to the
divelements with thearia-expandedattribute. The roleformis likely the best option in these scenarios.