Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search DV] Display deprecation and vulnerabilities on search page. #9440

Merged
merged 12 commits into from
Apr 26, 2023
Merged

[Search DV] Display deprecation and vulnerabilities on search page. #9440

merged 12 commits into from
Apr 26, 2023

Conversation

dannyjdev
Copy link
Contributor

@dannyjdev dannyjdev commented Mar 24, 2023 •
edited
Loading

Changes

  • Retrieve Deprecation and Vulnerabilities from Search Service.
  • Added Deprecation and Vulnerabilities properties to Package.
  • Display badges on search page.

Screenshots

Vulnerable and Deprecated

Only Deprecated

Only Vulnerable

Vulnerability title

Deprecation title

Addresses

@dannyjdev dannyjdev requested a review from a team as a code owner March 24, 2023 20:48
@dannyjdev dannyjdev changed the title [D&V] Display deprecation and vulnerabilities on search page. [Search DV] Display deprecation and vulnerabilities on search page. Mar 27, 2023
joelverhagen
joelverhagen requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about the new [NotMapped] properties on the entities.

drewgillies
drewgillies previously requested changes Mar 30, 2023
View reviewed changes
src/NuGetGallery/Views/Shared/_ListPackage.cshtml Outdated Show resolved Hide resolved
src/NuGet.Services.Entities/Package.cs Outdated Show resolved Hide resolved
keylime-unicorn
keylime-unicorn reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@keylime-unicorn keylime-unicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made some suggestions for the Deprecation Title.

src/NuGetGallery/Helpers/WarningTitleHelper.cs Outdated Show resolved Hide resolved
src/NuGetGallery/Helpers/WarningTitleHelper.cs Show resolved Hide resolved
src/NuGetGallery/Helpers/WarningTitleHelper.cs Outdated Show resolved Hide resolved
joelverhagen
joelverhagen previously approved these changes Apr 5, 2023
View reviewed changes
joelverhagen
joelverhagen previously approved these changes Apr 21, 2023
View reviewed changes
@dannyjdev dannyjdev dismissed drewgillies’s stale review April 21, 2023 23:37

Review already addressed.

@dannyjdev dannyjdev merged commit 3ebfdea into dev Apr 26, 2023
@dannyjdev dannyjdev deleted the dev-dj-searchdep-vul branch April 26, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agr agr agr left review comments

@joelverhagen joelverhagen joelverhagen approved these changes

@keylime-unicorn keylime-unicorn keylime-unicorn left review comments

@zhhyu zhhyu Awaiting requested review from zhhyu

@drewgillies drewgillies Awaiting requested review from drewgillies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dannyjdev @joelverhagen @agr @drewgillies @keylime-unicorn @zhhyu