Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Removed incorrect role attribute from breadcrumb headings #9311

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

advay26
Copy link
Member

@advay26 advay26 commented Nov 14, 2022

Addresses #9310

The breadcrumb headings on pages like the 'Report Package' page were flagged for having the "list" role on an <h1> tag. Since these serve more as headings anyway, I simply removed the role attributes from these elements without adding anything (<h1> tags are announced as headers anyway), and FastPass doesn't flag it anymore.

Previously,
image

After the change,
image

@advay26 advay26 requested a review from a team as a code owner November 14, 2022 23:55
@advay26 advay26 merged commit f472850 into dev Nov 15, 2022
@advay26 advay26 deleted the advay26-a11y-report-abuse branch November 15, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants