[A11y] Make Windows Narrator announce redesign tabs properly #8799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Sep 8, 2021
| <i class="ms-Icon ms-Icon--Dictionary" aria-hidden="true"></i> | ||
| README | ||
| </a> | ||
| </li> | ||
|
|
||
| activeBodyTab = activeBodyTab ?? "dependencies"; |
There was a problem hiding this comment.
Currently it's impossible for the dependencies or the release notes tabs to be the active tab by default. However, I still set and use activeBodyTab on these tabs to prevent bugs if we ever re-order tabs.
agr
approved these changes
Sep 9, 2021
lyndaidaii
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap 3 tabs do not have
aria-expandedoraria-selectedattributes until the user switches the tab. This causes issues with Windows Narrator. This change manually adds thearia-expandedandaria-selectedattributes to ensure Windows Narrator properly announces these tabs.Part of #8790