Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bullet point for tasklist #8629

Merged
merged 3 commits into from
Jun 21, 2021
Merged

remove bullet point for tasklist #8629

merged 3 commits into from
Jun 21, 2021

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Jun 10, 2021

Remove bullet point for task list when we render readme markdown

before:

After:
display page:
displayTaskList
upload page:
uploadtasklist
manage package page:
editTaskList

Addresses #8506

@lyndaidaii lyndaidaii requested a review from a team as a code owner June 10, 2021 04:44
@loic-sharma
Copy link
Contributor

loic-sharma commented Jun 10, 2021

Does this break lists? For example, what does this markdown look like?

My list:
* Item 1
* Item 2

My second list:
1. Item 1
2. Item 2

My todo:
* [ ] Item 1
* [ ] Item 2

}
}

#readme-preview{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#readme-preview{
#readme-preview {

@lyndaidaii
Copy link
Contributor Author

Does this break lists? For example, what does this markdown look like?

My list:
* Item 1
* Item 2

My second list:
1. Item 1
2. Item 2

My todo:
* [ ] Item 1
* [ ] Item 2

With current changes, it won't break the list
tasklist

@lyndaidaii lyndaidaii merged commit abd29b3 into dev Jun 21, 2021
@dannyjdev dannyjdev mentioned this pull request Jun 29, 2021
5 tasks
@joelverhagen joelverhagen deleted the markdownTaskList branch August 22, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants