Add accessible popovers to vulnerability alerts #8624
Conversation
| setTimeout(function () { | ||
| checkmarkImage.popover('destroy'); | ||
| }, | ||
| 1000); |
There was a problem hiding this comment.
Is 1 second enough for pop over dismissal? Is that a standard timeout value, do we use the same values across our site?
There was a problem hiding this comment.
We do--this is what we're using on the existing popover on reserved checkmarks on the package list.
There was a problem hiding this comment.
(note that the timer starts ticking on mouseleave)
| }, | ||
| 1000); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Its been a while I've worked on UI changes, but don't we have a common.js or something that is loaded by all the scripts where you could add this function in and share it across different JS scripts?
see nuget.copyTextToClipboard function that we use in similar way.
There was a problem hiding this comment.
I'll check it out--thanks!
There was a problem hiding this comment.
Yes, that worked well. I've included this change.
drewgillies
force-pushed
the
dg-a11y-popoversonpvaalerts
branch
from
6422994
to
7b77e9b
Compare
Addresses #8623.