Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Moved aria-labelledby so that announcer says correctly radio button grouping. #8538

Merged
merged 1 commit into from
Apr 26, 2021
Merged

[A11y] Moved aria-labelledby so that announcer says correctly radio button grouping. #8538

merged 1 commit into from
Apr 26, 2021

Conversation

dannyjdev
Copy link
Contributor

  • Moved aria-labelledby to label instead of the input element.

With this change it's more clear that radio button is checked or not when traversing the page with arrow keys.

Addresses #8495.

@dannyjdev dannyjdev requested a review from a team as a code owner April 22, 2021 01:01
@dannyjdev dannyjdev merged commit 69898de into dev Apr 26, 2021
@loic-sharma loic-sharma mentioned this pull request Apr 26, 2021
Closed
9 tasks
@joelverhagen joelverhagen deleted the dev-dj-a11y-radiobutton-group branch August 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewgillies drewgillies drewgillies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannyjdev @drewgillies