Hotfix: Don't attempt to send emails if they have no recipients #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
chenriksson,
cristinamanum,
skofman1 and
zhhyu
scottbommarito
commented
Nov 8, 2018
| @@ -202,11 +202,8 @@ | |||
| <EmbeddedResource Include="Infrastructure\MigrateUserToOrganization.sql" /> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="NuGet.Services.Entities"> | |||
There was a problem hiding this comment.
I removed these dependencies because they are transitively pulled in by NuGet.Services.Messaging.Email. I thought having this single dependency to rev will make this easier to manage in the future.
I have no problem with reverting this back if you think this isn't a good idea.
loic-sharma
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns Gallery with NuGet/ServerCommon#222