Consume NuGet.Services.Entities and NuGet.Services.Messaging.Email #6588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierdecoster
requested review from
joelverhagen,
agr,
loic-sharma,
chenriksson,
cristinamanum,
skofman1 and
scottbommarito
xavierdecoster
commented
Oct 23, 2018
| @@ -7,8 +7,6 @@ public static class CoreConstants | |||
| { | |||
| public const string AdminRoleName = "Admins"; | |||
|
|
|||
| public const int MaxPackageIdLength = 128; | |||
There was a problem hiding this comment.
This is now a constant in NuGet.Services.Entities.
| @@ -1442,7 +1444,6 @@ | |||
| <Compile Include="Services\IPackageService.cs" /> | |||
| <Compile Include="Services\PackageService.cs" /> | |||
| <Compile Include="Configuration\AppConfiguration.cs" /> | |||
| <Compile Include="Constants.cs" /> | |||
There was a problem hiding this comment.
Renamed NuGetGallery.Constants to GalleryConstants to reduce/avoid type collisions in views, as both NuGetGalllery and NuGet.Services.Entities are known namespaces in each razor view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ServerCommon.slnNuGetGallery.Coreand consumesNuGet.Services.Messaging.EmailinsteadHopefully, this will also help us limit the dependency on
NuGetGallery.Coreelsewhere :)