GetEtagAsync #6577
Merged
GetEtagAsync #6577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamanum
requested review from
joelverhagen,
shishirx34,
chenriksson,
scottbommarito,
loic-sharma,
zhhyu,
ryuyu and
agr
joelverhagen
approved these changes
Oct 18, 2018
| string folderName, | ||
| string fileName) | ||
| { | ||
| return await Task.FromResult<string>(null); |
There was a problem hiding this comment.
It would be clearer to throw NotImplementedException.
| fileName = fileName ?? throw new ArgumentNullException(nameof(fileName)); | ||
|
|
||
| var container = await GetContainerAsync(folderName); | ||
| var blob = container.GetBlobReference(fileName); |
There was a problem hiding this comment.
When would this return null?
There was a problem hiding this comment.
If the blob doesn't exist, FetchAttributesAsync will throw. If the intended behavior is to return null if the blob doesn't exist, I'd rename the method. Maybe something like GetETagOrNullAsync
There was a problem hiding this comment.
Updated the name and also to catch the case of FetchAttributesAsync throwing.
| @@ -426,6 +426,24 @@ public async Task<Uri> GetFileReadUriAsync(string folderName, string fileName, D | |||
| } | |||
| } | |||
|
|
|||
| public async Task<string> GetETagAsync( | |||
There was a problem hiding this comment.
Don't we need a method that calls this in the package file service?
There was a problem hiding this comment.
I would not add it until needed.
shishirx34
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an api for reading the etag for an azure blob.