Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbols UI Fixes #6576

Merged
merged 5 commits into from
Oct 18, 2018
Merged

Symbols UI Fixes #6576

merged 5 commits into from
Oct 18, 2018

Conversation

shishirx34
Copy link
Contributor

Addresses #6559

UI changes:

.nupkg vs .snupkg
image

warning and metadata:
image

delete default to dropdown:
image

@shishirx34
Copy link
Contributor Author

@diverdan92 - please review the UI and strings.

@diverdan92
Copy link

diverdan92 commented Oct 18, 2018 •
edited
Loading

@shishirx34 -
Warning and metadata:

There is an existing symbols package (.snupkg) for the below package ID and version. Submitting this request will replace the previously uploaded symbols package as well as the corresponding symbol files from the symbol server.

Delete:

Deleting this symbols package will remove all symbols in this package from the symbol server and make them unavailable.

Otherwise, LGTM.

cristinamanum
cristinamanum reviewed Oct 18, 2018
View reviewed changes
src/NuGetGallery.Core/Extensions/PackageExtensions.cs
public static bool IsLatestSymbolPackageAvailable(this Package package)
{
var latestSymbolPackage = package.LatestSymbolPackage();
return latestSymbolPackage != null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it needs to be the latest and not getting the available package if any?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right it could be any available package, but given that we do not show Download symbols link when an replacement snupkg fails validation(or if its validating) it kind of gets confusing when uploading the symbols. I agree the overall UI needs to be better around symbols view. I will create a tracking issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a tracking issue: https://github.com/NuGet/Engineering/issues/1797

@shishirx34 shishirx34 merged commit cdbfae0 into dev Oct 18, 2018
@joelverhagen joelverhagen deleted the symbols-nit-fixes branch July 1, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristinamanum cristinamanum cristinamanum approved these changes

@scottbommarito scottbommarito Awaiting requested review from scottbommarito

@joelverhagen joelverhagen Awaiting requested review from joelverhagen

@chenriksson chenriksson Awaiting requested review from chenriksson

@agr agr Awaiting requested review from agr

@diverdan92 diverdan92 Awaiting requested review from diverdan92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shishirx34 @diverdan92 @cristinamanum