Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SemVerLevel propagation in Odata Next links. #5582

Merged
merged 6 commits into from
Mar 7, 2018

Conversation

ryuyu
Copy link
Contributor

@ryuyu ryuyu commented Mar 6, 2018

Addresses #5433

{
if(semVerLevelKey == SemVerLevelKey.SemVer2)
{
queryBuilder.Append("semVerLevel=2.0.0&");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use const SemVerLevelKey.SemVerLevel2.

Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address comment then :shipit:

Copy link
Contributor

@skofman1 skofman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryuyu ryuyu merged commit eeb6929 into dev Mar 7, 2018
scottbommarito pushed a commit that referenced this pull request Mar 15, 2018
scottbommarito pushed a commit that referenced this pull request Mar 15, 2018
scottbommarito pushed a commit that referenced this pull request Mar 15, 2018
scottbommarito pushed a commit that referenced this pull request Mar 15, 2018
@ryuyu ryuyu deleted the ryuyu-fix-odata-next-link branch March 21, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants